Responsive testimonials grid section | htm5, css3

Community feedback

• 

  P

  David Lemvigh•200

  @dlemvighPosted about 2 months ago

  The Visuals

  • Looks really good
  • Avatar outlines a bit different than design, but looks good
  • Nice 4, 3, and 1 column layouts
  • A bit extra body margin on mobile layout compared to design, making the content very squezed on when get below 400px
  • Missing "watermark" on purple card (also found it annoying to add myself without getting it on top of the text, but find a nice way by setting background-image on the card).

  Visually really good, only small notes

  The Code

  • The is an attempt at css grid, but then a lot of flexbox inside doing most of the work (grid-template-columns: repeat(6); - repeat is missing its second parameter so gets ignored)
  • A bit of grid and flexbox nesting, would have been nice to have been done with a single grid. Maybe using order to put the "kira" card on the bottom.
  • Well structured html
  • Nice use of css variables

  Flexbox usage really good. Grid usage could have been better. But in general really nice solution

  0

  ---

  

  P

  Ishmael Sunday•230

  @okayishmaelPosted about 2 months ago

  @dlemvigh For the for the review. I made changes.

  0