Design comparison
SolutionDesign
Solution retrospective
any feedback would be much appreciated <3
Community feedback
- @fidellimPosted about 3 years ago
Hi @InKABuser,
Great work finishing the project. Some suggestions I would like to share are of the following:
- Heading tags are not in order. This is important for assistive technology users to navigate the website. Make sure that if you use a heading tag, h1 comes first, and don't skip a heading.
- Include this code in a
<footer>
tag to solve accessibility issues.
<div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Ahmed Jamal</a>. </div>
- Use the
<main>
tag as a parent tag. Then use the<article>
as a child tag.
I hope these help :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord