Alex• 3,130
@Alex-Archer-I
Posted
Hi!
You did a decent work, but there are could be a couple of semantic improvements =)
Every page should contain main tag. Since this project is quite simple it could be the .card element. Also a should be inside li, not vice versa.
And I recommend you use this trick for better responsibility.
.card {
width: 95%;
max-width: 24rem;
}
It will keep your container 24rem in the big screens and allow it to adjust on the small ones. You can omit width if you want that element to take 100% of mobile screen. That way give you a bit more control of the container width, because for now it depends of the biggest element inside (p in your case).
Oh, and you can use text-decaration: none to links to get rid of underlines =)
Hope that helps =)
Marked as helpful
1
