Design comparison
Solution retrospective
So far, I am proud of what I have achieved on this project(being able to consolidate my CSS knowledge and skills). Depending on the feedback I receive, I might do different things.
What challenges did you encounter, and how did you overcome them?I didn't know at first how to use the table HTML element and how to style it. I had small difficulties with adding padding only to the first column because the other column would always shift with the same padding distance applied to the first column. After researching, I discovered that you could set the max width in percentage to each column. In my case the full width would only be 50% of the available row width, regardless of what padding I would apply to the first column.
What specific areas of your project would you like help with?I don't know if the way I styled the whole project is the most efficient. I know everybody has his one way to style a html page, but there might be some best practices I didn't follow right. I would appreciate if you could point out what areas I could have improved or made them better.
Community feedback
- @Henr1queCruzPosted 7 months ago
Hello there! ๐First of all, congratulations on completing this challenge!
Your solution looks great!
I have a suggestion for improvement:
Reagarding Semantic HTML, I would suggest you to use the
<section>
tag instead of using<div>
s.Another observation I've made is that you're not utilizing the class for the
<hr>
tag<hr class="solid">
. You might want to consider using the<hr class="divider">
that you're already styling, or alternatively, you could remove the<hr>
tags and its corresponding styling, from your code altogether. Instead you could addborder-bottom
property to the appropriate classes such asingredients-container
andinstructions-container
.Keep up the great work! ๐
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord