Design comparison
SolutionDesign
Solution retrospective
feel free to give me feedback, thank you...
Community feedback
- @KarimAyman97Posted 9 months ago
Hi faridlakbar Great Job! I have some recommendations for you
1- try to use separate file for CSS styling * for example *
<head><link rel="stylesheet" href="styles.css" /></head>
this will help improving code readability2- try to change
<div class="card"> to a <main class="card">
and the<div class="attribution"> to a <footer class="attribution">
this does not affect your project visually but it improves SEO as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord