Design comparison
Solution retrospective
I learned a little more about responsive design, and i tried to follow the "rules" or tips that i saw on this page: , thinking first about the responsiveness of the site, and by doing that it was more easy completing this exercise, i learned to use variables in CSS(i don't know where i should write them, in this exercise i did it in the body, but some recommends in * or in something like ::root or something similar), also some functions in CSS as min or max, i never used them but i prefer that way instead of writing media queries(i'm not saying is bad using media queries, but i prefer this way, it's more easy and fast).
What challenges did you encounter, and how did you overcome them?I don't think a have a real challenge, but if you see something i can upgrade tell me, maybe using other tags instead of the one i use, i don't know, just tell me whatever you want.
What specific areas of your project would you like help with?I would like some tips, on responsiveness, and variable declarations, like is there a guide of good practices or something like that? if you have a link tell me in the comments, and for responsiveness i know the next path is about that topic but if you have a page or a tutorial about it, let me know!!. And there's something else, i dont know how to put links here, i mean, And you write in here and it looks like a link to that page or material, understand what i mean??
Community feedback
- @StroudyPosted 2 months ago
Well done on getting this far! You’re clearly putting in the effort, and it shows. Just a few things I noticed that could enhance your solution…
Place variables in
:root { }
for global access, ensuring consistent usage throughout the stylesheet, rather than limiting them to thebody
element, which restricts their scope.body { --color-white: hsl(0, 0%, 100%); --color--stone: hsl(30, 54%, 90%); --color-Stone1: hsl(30, 18%, 87%); --color-text: hsl(30, 10%, 34%); --color-Stone3: hsl(24, 5%, 18%); --color-title : hsl(14, 45%, 36%); --color-instruction : hsl(332, 51%, 32%); --color-background : hsl(330, 100%, 98%); --background-color: var(--color-background); }
-
The
justify-content: center;
on your main is not doing anything because its being centered by youralign-items: center;
, -
Using
max-width: 100%
ormin-width: 100%
is more responsive than justwidth: 100%
because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Developers should avoid using pixels (
px
) because they are a fixed size and don't scale well on different devices. Instead, userem
orem
, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter. -
Using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,
-
This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation),
<meta>
description tag missing that helps search engine determine what the page is about, Something like this<meta name="description" content="" />
Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord