Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive qr-code-component using HTML, CSS and Media Queries

@callmeog01

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello developers, I would like a review on my code to know if what built is best practices

Community feedback

Travolgi 🍕 31,400

@denielden

Posted

Hi Callmeog, I took some time to look at your solution and you did a great job!

Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • to make it look as close to the design as possible add width: 20rem and padding: 1rem to container class and remove all margin
  • add width: 100% and border-radius: 1rem to img element
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

Overall you did well 😉

Hope this help and happy coding!

Marked as helpful

1
vcodey 270

@v-codey

Posted

hey @callmeog01, good work on this challenge there are some issues with the html , my browser is telling me this site is unsafe. so i reviewed the code and done some important changes . check out your github

Marked as helpful

1
IRVINE MESA 1,855

@DrMESAZIM

Posted

well done @callmeog01 .this is good work

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord