Responsive qr-code-component using HTML, CSS and Media Queries

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Callmeog, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • to make it look as close to the design as possible add width: 20rem and padding: 1rem to container class and remove all margin
  • add width: 100% and border-radius: 1rem to img element
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1
• 

  vcodey•270

  @v-codeyPosted over 2 years ago

  hey @callmeog01, good work on this challenge there are some issues with the html , my browser is telling me this site is unsafe. so i reviewed the code and done some important changes . check out your github

  Marked as helpful

  1
• 

  IRVINE MESA•1,855

  @DrMESAZIMPosted over 2 years ago

  well done @callmeog01 .this is good work

  Marked as helpful

  0