Design comparison
Community feedback
- @godmayhem7Posted almost 2 years ago
hey @ageddesi your code was really awesome 👏👏🎉. here are some tips i have that will help you better your code; i went through your code and noticed that all your layout-sections where just div-tags, wrapping your codes around div-tags looks kinda messy you should try adding other layout-sections like the main-tag(<main></main>),nav-tag(<nav></nav>),section-tags(<section></section>),header-tag(<header></header>) and footer-tag(<footer></footer>). these tags are self explanatory and they help out when someone is trying to understand your code. the rest of your code was okay 👌👌, hope this feedback was helpful 👍👍👍
0@ageddesiPosted almost 2 years ago@godmayhem7 thanks. I had not approached the challenge taking into account full html standards i was soley focused on the css side.
Once i had submitted it i noticed this was also required by the solution as filly rounded so will be updating this solution soon and remembering that for future challenges.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord