Design comparison
Community feedback
- @lidiakrajewskaPosted over 2 years ago
Good job!
I noticed that on mobile the component is not centered perfectly. It's caused by the attribution div. You can take attribution div outside of the container and add to body styles:
body { flex-direction: column; align-items: center; }
This should solve the issue. Also you can wrap your container div in <main> tag (it'll solve the accessibility issue) :)
Marked as helpful0@AhmedFawzi44Posted over 2 years ago@lidiakrajewska I haven't noticed that the component in the tiny width become not centered I have set the font size of the attribution to 10px instead of 12px and it has solved the problem ..
The component is not centered perfectly in the galaxy fold [Under 350px width] the font size was big for the small width ..
your way doesn't work because of the {min-height:100vh;} which i had assigned to the container ..
Thanks for your help
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord