@emkuma
Posted
I would place the design in the middle of the viewport.
I'm just a newbie to css. Your css code looks "clean". Your code uses more sophisticated techniques than mine.
Good job!
Marked as helpful
@iMohamed-E
Posted
Yeah you can do that too but i wanted the text underneath it to bo close to it too , but ty <3@emkuma
@KapteynUniverse
Posted
@iMohamed-E For better centering, you can use flex or grid.
body {
display: flex;
justify-content: center;
align-items: center;
min-height: 100vh;
}
or
body {
display: grid;
place-content: center;
min-height: 100vh;
}
Try to avoid hard coded values like width: 350px; , use max-width: 350px; instead, max-width: 20 rem would be even better. Using em/rem units is better for responsiveness.
Images need meaningful alt texts, unless they are decorative. For this challenge, something like "Frontendmentor.io" or "QR code to Frontendmentor.io" would be better i believe.
Marked as helpful
@iMohamed-E
Posted
Ty so much , that was helpful and i will work on it <3 @KapteynUniverse
