Responsive QR code page using Flexbox

Community feedback

• 

  Adriano•38,250

  @AdrianoEscarabotePosted about 4 hours ago

  Hello Rodel Advincula, Welcome to Frontend Mentor!!

  How are you? I was really pleased with your project, but I’d like to offer some advice that might help:

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem!

  link -> px to rem

  The rest is spot on.

  Hope it’s helpful to you. 👍

  Marked as helpful

  0
• 

  hitmorecode•6,660

  @hitmorecodePosted 1 day ago

  Nice well done looks good. Just a few pointers

  • It's best practice to add some kind of CSS reset, here is an example of a simple CSS reset

  * {
    margin: 0;
    padding: 0;
    box-sizing: border-box;
  }
  

  With this you don't have to add margin: 0; or padding: 0; anymore.

  • By default the body already has 100% width, so you don't need to add this.
  • As for the height of the body, it's best practice to user min-height instead of height.

  I hope you find this helpful. Keep it up 👌👍

  Marked as helpful

  0
• 

  ed•20

  @Barcode77Posted 1 day ago

  your html code was way simplified than mine. i created another branch and made some changes to my original code. check it out!also, is nesting advisable?

  0