Submitted about 1 month ago
Responsive Product preview card with html and css using BEM
@Djamel1133
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
my first : -BEM convention naming -Mobile-first approach
Community feedback
- @ZxjklpPosted 2 days ago
Hi @Djamel1133,
Great job on the project! I’d love to share my feedback.
- Since your
<link>
includesfont-display: swap
, you don't need to repeat it in your CSS file. - Image elements do not have explicit
width
andheight
.
<img class="card__image" src="assets/images/image-product-desktop.jpg" alt="parfum image">
Marked as helpful0 - Since your
- @MizanSafinPosted about 1 month ago
I think very nice & perfect design I love it , But there is slight problem in typography like- font-weight of product name(perfume).
2@Djamel1133Posted about 1 month agoThank you very much, @MizanSafin. I am really struggling, especially with typography, with or without a Figma file. See you soon, insha Allah, and thank you again.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord