Responsive page using flexbox and media queries

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Bezies•1,230

  @BeziesPosted over 1 year ago

  @0xAbdulKhalid Thank you again !

  0
• 

  Boubaker Jouini•50

  @boubakerjouiniPosted over 1 year ago

  Hello @Bezies good work ! I have some feedbacks that can help you.

  • For this challenge don't use the % or the vw, vh for the width and height. make it a fix size using px or rem as it doesn’t take all the space at first. and just do a breakpoint where the container take the full width.

  • Avoid using absolute, you can center a div with the flexboxs

  Good luck with your future projects ✌️

  Marked as helpful

  0

  ---

  

  Bezies•1,230

  @BeziesPosted over 1 year ago

  @boubakerjouini Thanks for taking the time to get back to me. I'll take that into account for my next project.

  0