Skip to content
Submitted about 3 years ago

Responsive order summary component website

Costi Voicu•295
@CostiVoicu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any feedback is highly appreciated!

Community feedback

  • dewslyse•3,025
    @dewslysePosted about 3 years ago

    Hello Costi! Nice work on your submission. Really well implemented. Some things to note:

    • You could use more semantic sectioning elements within your html. Your could wrap your main content in a <main>. E.g:
    <body>
   <main>
   .
   .
  </main>
</body>

    This would help with some accessibility issues.

    • You could also wrap your img in a figure element or even a header and replace <div class="main> with <main class="main">
    • Since the background images are decorative and don't have an alt, you could add aria-hidden: true to them for improved accessibility
    • You may want to update your report to reflect the changes you'll make to the code.

    Happy coding

    Marked as helpful
    3
    Costi Voicu•295
    @CostiVoicuPosted about 3 years ago

    @dewslyse Thank you so much for your feedback!

    0
  • Fluffy Kas•7,715
    @FluffyKasPosted about 3 years ago

    Hey,

    Your solution looks very good to me! The only thing I'd argue with is having inline CSS applied to your illustration. Since you linked a stylesheet to your html, I'd say it's probably not good practice.

    Also one small thing: you could try getting into the habit of writing your own README. Frontend Mentor provides even a template for this. The file that you uploaded as your README is actually the information provided for YOU to complete the challenge. ^^

    Marked as helpful
    3
    Costi Voicu•295
    @CostiVoicuPosted about 3 years ago

    @FluffyKas I will consider to write my own README and stop using inline CSS. Thank you!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord