Responsive Order Summary Card using Tailwind CSS and Flexbox
Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
This comment was deleted over 1 year ago
0@ecemgoPosted over 1 year ago@0xAbdulKhalid
I needed to use a landmark instead of a
<section>
tag. The accessibility issue was fixed when I used the<header>
tag. It was not a background image issue. Still, thank you for your feedback.0@0xabdulkhaliqPosted over 1 year ago@ecemgo
- Actually the
<header>
element represents introductory content, typically a group of introductory or navigational aids.
- It may contain some heading elements but also a logo, a search form, an author name.
- But here, You used it for just an
image
withabsolute
positioning, it's a bad practice. It will cause severe accessibility issues.
- Applying the
image
asbackground
forbody
is enough to make our code accessible for screen reader.
- In the end choice is yours, if you will to lack accessibility then go ahead use
sementic
element fornon-semantic
purposes.
Hope am helpful !
0@ecemgoPosted over 1 year ago@0xAbdulKhalid
Thank you for your suggestion on how to implement the design feature but I would like to clarify that I am currently using Tailwind CSS for this project. Thus, I'm sure that the method you suggested works well with Pure CSS, but I am unable to modify the CSS file in the way you proposed with the Tailwind CSS framework.
0 - Actually the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord