Design comparison
Solution retrospective
Hello guys,
This is my second attempt to recreate this design. This was one of my first designs to implement before I was fully familiar with concepts like:
- keeping your code DRY
- using the right units
- CSS variables
Appreciate any feedback! :)
Community feedback
- @phaevourkhrisPosted almost 3 years ago
Hi Noemi, I think you really did a good job. Goodluck
Marked as helpful1@NomiDomiPosted almost 3 years ago@phaevourkhris Thanks so much! :) I really appreciate it!
0 - @al3xbackPosted almost 3 years ago
Hi Noemi,
It is better to change
height
tomin-height
on body. try to zoom-in until the browser height smaller than the content, and see the difference. min-height allows better view to see full content.Marked as helpful1@NomiDomiPosted almost 3 years ago@al3xback Done! Thanks so much for your feedback! :)
0 - @skyv26Posted almost 3 years ago
Hi! Noemi, Really Good, you did it this time really awesome.
Add
overflow: hidden
in .main css class.Overflow Nice Work. Now move on next one.
Good Luck
Marked as helpful1@NomiDomiPosted almost 3 years ago@skyv26 Thank you so much! Just implemented your feedback!
1@skyv26Posted almost 3 years ago@NomiDomi Your welcome. Waiting for your next challenge solution.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord