Responsive Layout with HTML5, CSS Grid and Flexbox

Community feedback

• 

  Jesús Alejandro Atao•970

  @JesusAtao96Posted almost 4 years ago

  Hello Wilder Rincon 👋

  Excellent work on this challenge 🎉🎉🎉. Just add transition: background .5s on the body and the header class, now press the dark / light button and the background color change is smoother ✨.

  Happy coding 😊.

  1
• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi,

  I really like this one, well done! I particularly like your use of prefers dark mode in your js, that's a great touch.

  Your solution is very nearly accessible at the moment, it jusy needs a few small tweaks:

  1. Dark mode needs to be inside your checkbox label. That's really important as assistive tech currently has no way of knowing what the checkbox does.

  2. Remove the word 'icon' from all alt attributes. It doesn't need to be there and will make some parts read poorly (like "image, up icon, twenty")

  3. Don't use article tags unless it's really standalone content, ie a heading and subconent at least.

  I hope these accessibility tips are helpful (if they are, upvote). I'll definitely be favouriting this solution!

  1
• 

  Wilder Rincon•20

  @wildsrinconPosted almost 4 years ago

  Thank you so much for yours feedbacks, I have already made some changes suggested by you, thank you for your comments.

  0