Submitted about 2 years ago
Responsive landing page using SCSS, Grid, Flexbox, and JS
@jaycgreenwald
Design comparison
SolutionDesign
Solution retrospective
- At what point does increased precision no longer pay dividends? I recently chose a line height of 1.07. Is that too granular of a value? Would it be better to use 1.0 or 1.1? (For the record, I have read Josh W. Comeau's article about pixel perfection. This is more about how many decimal places are relevant.)
- Is it okay to use percentage for padding like I did to make my hero image to appear? (It's ".hero" selector in the _mobile partial.)
- Did I achieve some responsiveness? I could make it look good at 1440x800, but at wider sizes not so much (in my opinion). But adding an extra media query keeps the page centered starting at the 1441px mark. I think this looks better at those wider dimensions.
- Anything else you notice.
Thank you in advance for the feedback!
Community feedback
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord