Responsive landing page using CSS Grid and SASS

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these recommendation:

  				**HTML**
  

  ✅ Write Code Comments. It’s best practice to write human-readable code. Tried to comment your block of code. It will help you or any other developer to refactor the piece of code blocks.

  ✅ Follow a consistent HTML format. It is important to remain consistent in your HTML style. You can use prettier to help you with that but the goal is to always follow a consistent way you code your markup.

  <div class="intro__main-content flow"> <- BEM style
            <h1 id=intro-heading""   <- quote lost, dash case style
  

  				**CSS**
  

  ✅ Write consistent CSS. At the beginning part of the project you can set some rules for maintain throughout to your entire stylesheet. If you follow the convention or BEM, you’ll be able to write CSS without being afraid of side effects.

  ✅ Use rem’s or em’s. Using rem’s or em’s is more dynamic way instead of using pixels. Try to use rem’s or em’s rather than pixels.

  ✅ Use Clamp . The clamp function make smaller and simple CSS to control element width.

  width: clamp(100px, 50%, 300px);
  

  ✅ Use CSS Variables . Making the code flexible is equally important so that refactoring won’t be a problem for you. One of the best ways to achieve this is variables.

  I hope my feedback will be helpful. You can mark it as useful if so 👍 it is not difficult for you, but I understand that my efforts have been appreciated

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  0

  ---

  

  Abed Fetrat•450

  @abedfetratPosted over 2 years ago

  @isprutfromua Thank you for your thorough review. 👍 I haven't really wrapped my head around clamp. Where do you see fit to use it?

  0

  

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  @abedfetrat intro__image , for example

  1