Responsive landing page - Sass and JS

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  Hey Jamie, congrats on completing this challenge! I just wanted to note two things that stood out to me the most.

  • The mobile menu icon is shifting positions when you toggle open and close. It's more noticeable as we get into the medium widths. The spacing on the nav list items also look off.

  • The image gallery between 911px to about 1020px could use some editing, with the last row misaligned with the others and the SEE ALL button at the end seems to be part of the collection.

  Hope this helps :-)

  1

  ---

  

  Jamie Wales•90

  @Jamie-WalesPosted almost 4 years ago

  @emestabillo Hi thanks for the feedback, my JS adds a fixed position to those elements so they stick to the screen even if you scroll. I tried to turn off x scrolling on mobile menu but it didn't work any advice would be appreciated.

  Fixed the button and the menu aswell :)

  Thanks again! Jamie,

  1

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted almost 4 years ago

  @Jamie-Wales Oh ok cool! I took a closer look at the code and maybe if you keep the logo and ul elements in one parent, you can apply fixed only to the parent. I see there's also an !important declaration on keeping it fixed, which means there may be some specificity issues with the current code. I suggest a bit more cleanup, and to keep only one set of uls for the header. Here is how I did it, if you're looking for ideas. Hope this helps! Again! 😄

  0