Responsive landing page made with CSS flex and jQuery.
Design comparison
Solution retrospective
would love to hear feedbacks or suggestions. thank you.
Community feedback
- @tedikoPosted over 3 years ago
Hello, Rahul kumar Gautam! 👋
Good job on this challenge! Your solution responds well and looks nice. Some tips from me:
- Since your
.intro
image is decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers. - Add
:focus
pseudo class to interactive elements like anchors, buttons etc. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles. - Your image with hamburger icon should be a
<button>
element since it trigger some action. footer_icons
should be wrapped with<a>
tags since it will redirect to other page.
Good luck with that, have fun coding! 💪
0@RahulKumarGautam1636Posted over 3 years ago@tediko yes sir, of course i will explore the points you just told me about to improve my work. Thank you for these suggestions, i really appreciate it.
0 - Since your
- @KodeeshwararPosted over 3 years ago
if use proper class name or BEM method your website easy way to manage and will be a good developer
0@RahulKumarGautam1636Posted over 3 years ago@Kodeeshwarar yes bro i am not good in naming classes and id's. I will work on it. Thank you for your time.. 😊
0@KodeeshwararPosted over 3 years ago@RahulKumarGautam1636
Your content that looks quite good bro
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord