Responsive Huddle landing page with sass

Community feedback

• 

  Adam•430

  @aemann2Posted over 3 years ago

  It looks like the background image for your desktop version isn't quite taking up the whole page. You can fix this by setting min-height on your body element to 100vh instead of 100%, and adding background-size: cover to your body selector.

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Allamprabhu! 👋

  Good job on this one! Your solution responds well and overall looks good. Here's my suggestions:

  • Wrap your icons with anchro tag <a> to make them clickable. Additionaly you'd have to add some aria-label on it to describe it for screen readers users since icons are treated like there is no content within anchors so it won't be announced.

  Good luck with that, have fun coding! 💪

  0

  ---

  

  Allamprabhu•120

  @Allamprabhu2003Posted over 3 years ago

  @tediko Thanks for your suggestions.

  0