Responsive huddle landing page using grid

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Ricky! 👋

  Good effort on this challenge! 👍 It looks good on my mobile view! 👏

  Some areas that you could improve.

  • The same as the footer that needs to live outside the main landmark to have a role, the header also needs to live outside the main landmark to have a role as a banner. Also, it's great that you are not including the first section in the header element. 👍
  • The logo is one of the most important contents of the site so the logo should have alternative text. That content of information is used by screenreader users and bots to know what the site or the project is called.
  • Every page should only contain one h1 for every page, it works as an identifier for each page so that's why each page should only have one h1. I notice there are two h1. So, I would recommend making the second h1 as h2 instead.

  That's it! As far as the responsiveness goes, I don't see any issue or any overlap elements. I think if you fix all the accessibility issues that have been reported by Frontend Mentor and me, it would be a good thing since you have tagged this solution with the #accessiblity tag.

  I hope this helps! Keep up the good work! 👍

  Marked as helpful

  1

  ---

  

  Ricky•470

  @pyaetheiNPosted over 2 years ago

  Hey @vanzasetia! I was confused on where to put header tag but now I understand thanks to your feedback. I also learned more about accessibility and areas that need improvement from front end mentor and your kind report.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @pyaetheiN No problem! Glad it was helpful! 😄

  Marked as helpful

  1