@visualdenniss
Posted
Hello Batuhan,
nice work with the card. Few more suggestions:
-
you don't need height: 1.5em; and height: auto; , in fact, height: auto is the default. Also you should avoid giving fixed-heights anw.
-
max-width: 300px; or 285px seems a bit closer to the design. Also there seems to be a bit too much space above the h2 title, so you might consider reduce the margin top.
-
Also consider using a common css reset at the start of your projects: https://www.joshwcomeau.com/css/custom-css-reset/ It can help a lot with many issues
Hope you find this feedback helpful!π€
Marked as helpful
@BatuhanGQskt
Posted
@visualdenniss thank you for your review. I actually don't like fixed-heights and widths and trying to avoid them, but I missed this one. Thank you for pointing that out. I have removed the fixed-height, and thank you for the link.