Responsive Fylo landing page using grid

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Greetings, Ricky! 👋

  Good effort on this challenge! Well done on using the correct landmark elements for each page content! By doing that, you help the screen reader users navigate the site comfortably. 👏

  To change the logo color,

  • I did create a new file called logo-white.svg and then copy-paste the code from the original logo.svg.
  • After that, I changed the fill attribute to #fff and then finally referenced it using img tag to the logo-white.svg.

  I don't remember the exact fill attribute that needs to be changed but you can play around with it until you find the fill property that changed the Fylo to white.

  Some feedback:

  • Use button with type="submit" instead of <input type="submit">. Submit input is legacy.
  • The footer__link elements should be a link, not just a list.
  • The logo should have alternative text, use the company name as the alternative text. It's the important content of the page. Users of screen readers or search engine bots use that information to know what the site/project is called.

  Overall, great work. All landmark elements wrap the correct page content and I think if you fixed all the issues that have been reported, this will increase the quality of the site.

  I hope this information is useful! Keep up the excellent work! 👍

  Marked as helpful

  2

  ---

  

  Ricky•470

  @pyaetheiNPosted over 2 years ago

  Thank you so much for your feedback I really appreciate it, noted all your points!

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @pyaetheiN No problem! Glad to help! 😄

  1
• 

  Nasim Reja•220

  @nasim67rejaPosted over 2 years ago

  check thisplaylist

  Marked as helpful

  1

  ---

  

  Ricky•470

  @pyaetheiNPosted over 2 years ago

  Thanks for the amazing tutorial!

  0