Responsive FAQ page using javascript to display answers

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted almost 4 years ago

  Hello 👋! You used section for your .group elements and these elements are lacking headings, so it shouldn't be consider as section. Take look at semantic elements. This will improve your HTML code. Good luck!

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Valentin! 👋

  Nice work on this challenge! 👍 Your solution looks great, is responsive, and the accordion card works well (I like the transition between the open/closed states of the FAQ)! 👏

  I suggest,

  • Not switching to a mobile-friendly layout immediately at 1440px, since I think there's still room for the desktop layout of the site for a little while.
  • The top of the illustration is cut off on some smaller desktop screens in the mobile layout. You might want to add some margin or padding to make sure that there is always some space between the card and the top of the screen. 😉

  Keep coding (and happy coding, too)! 😁

  And happy holidays! 🎄

  0
• 

  ValouZ•245

  @ValouZPosted almost 4 years ago

  Thanks mate i'll check that

  0