Skip to content
Submitted almost 4 years ago

Responsive FAQ accordion using JS

Guliye•290
@guliye91
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...FAQ accordion card
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

HI Coders! I just finsihed 'FAQ accordion Card'. I used Javascript. DONT BOTHER THE DESIGN. I just wanted to practice my JS knowledge.

kindly gi through and give me feedback on issues of js functionality in js.

Community feedback

  • Amir Jacobs•165
    @Amir-JacobsPosted almost 4 years ago

    Hi Guliye

    I noticed a few things about your Javascript:

    • I'd use functions to make clear what is happening. You could make a function called resetAccordion() and a function called showAccordion().
    • I'd make a bit more use of comments.
    • The accordion can only be opened by clicking the icon, but it'd be more user-friendly to have it open upon clicking .question.

    Have a nice day. ✌

    2

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord