Design comparison
Solution retrospective
Any comments are welcome... thanks. And yes, I used JS for the accordion not CSS only (the HTML began to look unpleasant)
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Dela, I just checked you work and also tested mobile responsiveness. I noticed some issues that I am going to write and will try to add some suggestions or tips for betterment of your solution.
- I saw that for the very first time I clicked on question and the tabs expands with it answer's height, and it is ok till the point when 3rd accordian tab not opened, as I opened the third tab then along with tab's height, accordian height also changed. It should not be like this.
Add the fix height for accordian so that it never expand and still at its right position. Also you please on click of any accordian tab, only current tab expand and rest of all should be in collpased state. Because it is the requirement of this challenge, you have to follow the requirement.
- Your design is responsive but because of above problems, your accordian went outside from device viewport. You can also check this.
Overall Good work, and I hope you understand above issues.
Good Luck
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord