Responsive coming soon page using css grid, Sass

Community feedback

• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Joaquín González Tesoro,

  Congrats for completing the challenge ! 🙂

  I'd like to suggest :

  • Change background-repeat: none to background-repeat: no-repeat, none is not a valid value for this CSS property.

  • Change background-position: cover to background-size: cover, here the value cover is associated with the second one and not the first one.

  • Remove the error message from the input when it's not active.

  • For the grid part, I think that working with 2 rows and 2 columns here might be simpler. Also, while working with grid the fr unit is very convenient I don't think you've used it.

  Overall, well done for the challenge and happy coding ! 😃

  0

  ---

  

  Joaquín González Tesoro•30

  @JoaquinGTesoroPosted over 3 years ago

  @RayaneBengaoui Thank you for your feedback, it's really helpful. Soon I will update it P.S: Sorry for answering 5 days later.

  0