This is quite simple challenge when compared to others.
I wanted to use a package for validating email instead of using plain JavaScript just for testing out. I have installed validator.js and tried to link this up. Since this is client side validation, it is used as a standalone script. The script is around 70kb which I have copied and included. Is there any other way to implement the package without the entire file being loaded to the user?
Any feedback is highly appreciated. Happy Coding !!! 🎉
Account Deleted
Hey @santu369,
Nice work completing this challenge! Another way you can import the package could be through CDN - (Link here)[https://cdnjs.com/libraries/validator]
Use the link as a script reference in your index.html file and you should be good to go
//Kenny
@santu369
Posted
Thanks @ktra99 ✨, Didn't think of this approach. This seems to be a better way which does the same thing via CDN instead of copying the entire file.
Hello, shiva santosh jana! 👋
Good effort on this challenge! Your solution responds well. I am glad that you thought about accessibility with sr-only class for icon links aswell that you add :focus states. Here's my few suggestions:
.header__logo image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.paragraph or span for .header__detail.Good luck with that, have fun coding! 💪
@santu369
Posted
Hi @tediko ,
Thanks for the feedback and suggestions.🙌
.header__logo image is not decorative as per the design since it conveys the home page itself, if we remove it then we don't have any means to convey that it is Ping homepage. I got this info from Deque. Let me know if I am wrong here. Although, I would've wrapped that in an a tag which will better convey the meaning I think.
I was pretty dumb using a h2 there 😂, paragraph is a better option
@santu369 If you've wrapped that in an a tag then yes, you're 100% correct and then you have to leave alternative text to be something like "Ping - homepage" but since it does nothing since you didn't wrap it in an anchor tag it is decorative. Have a good one! :)
@santu369
Posted
@tediko my bad 😝. Thanks for the suggestions, helpful for my next projects.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
