Responsive code bar landing page using css flex

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div class="container"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • This solution also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  CSS 🎨:

  ---

  • And, We can use relative units instead of using pixels px in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Read more 📚.

  ---

  • And, use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  ---

  • So change, the following style rule

  body {
      height: 100vh;
  }
  

  ---

  • To this,

  ---

  body {
      min-height: 100vh;
  }
  

  I hope you find it helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Boluwatife Bonaventure•550

  @BoyutifePosted over 1 year ago

  @0xAbdulKhalid Thanks boss i will do the corrections and resubmit

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @Boyutife

  • Glad to hear that you are willing to correct those errors .

  ---

  • You don't want to resubmit.

  ---

  • Just alter your code in your github repository.

  ---

  • After fixed those issues, you want to generate a new screenshot.

  ---

  • You can found that button on top of design comparison section in this solution post

  ---

  • Generate new screenshot means it will validate your solution and generates a new report.

  ---

  • So after generating a new report, which will we can eventually clears the errors.

  Hope am helpful...🙌

  0

  

  Boluwatife Bonaventure•550

  @BoyutifePosted over 1 year ago

  @0xAbdulKhalid Have made the corrections i added the main semantic tag i removed the px from the width and height value in the img tag i used rem in my css i added sr-only

  honest i dont really have a clear and full understanding of the sr-only class

  what next

  0