Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive code bar landing page using css flex

@Boyutife

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • I found the project friend and easy
  • The media query part
  • Am interested in getting better

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage
  • So fix it by replacing the element <div class="container"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.
  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

  • This solution also generated accessibility error report due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

CSS 🎨:

  • And, We can use relative units instead of using pixels px in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Read more 📚.
  • And, use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
  • So change, the following style rule
body {
    height: 100vh;
}
  • To this,
body {
    min-height: 100vh;
}

I hope you find it helpful 😄 Above all, the solution you submitted is great !

Happy coding!

1

@Boyutife

Posted

@0xAbdulKhalid Thanks boss i will do the corrections and resubmit

0

@0xabdulkhaliq

Posted

@Boyutife

  • Glad to hear that you are willing to correct those errors .
  • You don't want to resubmit.
  • Just alter your code in your github repository.
  • After fixed those issues, you want to generate a new screenshot.
  • You can found that button on top of design comparison section in this solution post
  • Generate new screenshot means it will validate your solution and generates a new report.
  • So after generating a new report, which will we can eventually clears the errors.

Hope am helpful...🙌

0

@Boyutife

Posted

@0xAbdulKhalid Have made the corrections i added the main semantic tag i removed the px from the width and height value in the img tag i used rem in my css i added sr-only

honest i dont really have a clear and full understanding of the sr-only class

what next

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord