Design comparison
Solution retrospective
I would appreciate some feed back on how I could have optimise my CSS. Thank you :)
Community feedback
- @martinelias1312Posted almost 3 years ago
Hi @Eric-Ferole, i recommend using relative units like em, rem or % instead of absolute units (px). This will surely help with page responsiveness. Here is an article about units.
Hope this will help you for future challenges :)
0@Eric-FerolePosted almost 3 years ago@smradupan your are right. I read about rem. Seems pretty useful for responsiveness and accessibility. Thanks for you comment.
0 - @IEdiongPosted almost 3 years ago
Hello Eric 👋, your solution is almost 💯 pixel perfect. I did notice two things:
-
the
cancel
button is meant to have itstext-decoration
set tonone
-
Also, you should look into the accessibility and HTML issues raised here.
I hope this was helpful, Shalom!
0@Eric-FerolePosted almost 3 years ago@IEdiong Thanks for you comment. You are right. I'll take care of those issues later today.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord