Responsive body using Flex box

Community feedback

• 

  MrLanter•220

  @MrLanterPosted about 2 months ago

  Hey there, I hope everything's going well for you! Great job on your project.

  I have a few suggestions that might help improve it :

  Text : I highly recommend putting text in a <p> tag, instead of using <div>. This improves readability and maintenance.

  Text Colors : Check the text colors specified in the style-guid.md, the title and paragraph do not have the correct colors.

  HTML Semantic: Using semantic tags is recommended for readability, and SEO. Start using them by inserting tags such as <main>, <header>, <footer>, <article>. a detailed resource on this topic

  I hope this helps! Have a nice day

  Marked as helpful

  0

  ---

  

  Abdelrahman Soliman•10

  @Sol1manPosted about 2 months ago

  Thanks for your suggestions and encouragement @MrLanter! I appreciate the feedback. I'll definitely look into these improvements:

  I'll update the text to use <p> tags instead of <div> for better readability and and review the text colors according to the style-guid.md to ensure consistency. I'll also start using semantic tags, that was a great advise that i will use in any future project.

  1
• 

  P

  Ivaylo Ivanov•260

  @ValsCodesPosted about 2 months ago

  Great solution!

  Here are some tips:

  • take a closer look at the font, you can see that some of the text uses ligher font opacity
  • look into sematic HTML tags, simply adding role="main" to your first div is more than enough
  • your div is a little shorter than the design
  • you can up the padding of the div just a little more

  Keep going! Best regards!

  Marked as helpful

  0

  ---

  

  Abdelrahman Soliman•10

  @Sol1manPosted about 2 months ago

  Thanks for the tips and the encouragement @ValsCodes !

  I’ll use semantic HTML tags and I’ll check the font opacity to make sure it matches the design colors. I’ll also add padding slightly to align with the design. Appreciate your feedback—I'll keep improving. Best regards!

  0