Design comparison
Community feedback
- @YuliaLantzbergPosted 5 days ago
Hi Sushas.It's looking good. For me, even the background color you've chosen looks much nicer than the one from the original design. However, after the initial click on the share button, the footer appears not smoothly, jumping. It's because you create the elements on the flight and it takes some time. Simple manipulating classes allows to use transition property to make it nicer. Also, I noticed, that you use the var keyword for variables and it's not a good practice in modern js. Here is an article about it: https://medium.com/@conboys111/why-should-you-avoid-var-and-use-let-or-const-instead-in-javascript-1c8d10d7482a
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord