Design comparison
SolutionDesign
Solution retrospective
Not sure if the main div is centered vertically on page. Any feedback is appreciated!
Community feedback
- @tedikoPosted over 3 years ago
Hello, Gonca! π
Congrats on finishing another challenge! π Your solution looks very good and also responds well. Here's my few tips:
- You don't have to wrap every element into div. Add
.card-header
toh2
element instead. It also apply to.card-paragraph
and.card-button
divs. If it comes to image you can keep it in additional wrapper. - Change the
alt
attributes for the.card-icon
images, as they don't add any extra context for screen reader users. Since your images are decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies.
Good luck with that, have fun coding! πͺ
1@goncanegisPosted over 3 years ago@tediko youβre absolutely right, thank you so much for your detailed and insightful comment!
0 - You don't have to wrap every element into div. Add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord