Recipe page menu

Community feedback

• 

  P

  webdevbynight•410

  @webdevbynightPosted 3 months ago

  My feedback about your solution:

  • you should enhance the semantics of your HTML, by using elements such as main (to wrap the main content of the page), article (to wrap the whole recipe content) and section (to wrap the section about the preparation, at least);
  • “Preparation time” is a header and should be, therefore, tagged as a h2 rather than a b element;
  • if you use a table for tabular data, you should be aware of the th element and the scope attribute to make the table more accessible to screen reader users (by the way, the data concerned can be tagged as a definition list, with dl, dt and dd);
  • beware of text-indent: this property only indents the first line, so it is not appropriate for li elements (use margins or paddings instead);
  • on your reset stylesheet, avoid using pixels for font size, even to reset the default one (here is a video telling why);
  • even though you use SCSS, now you can replace Sass variables by custom properties in most cases.

  I hope this feedback helps you.

  0