Design comparison
Community feedback
- @hitmorecodePosted 2 days ago
Congratulations well done. Let me just point a few things
-
When switching to small screen size, there is a overflow. Your page is not fully adapted for small screen sizes. The overflow is being caused by display flex on the body.
-
It came to my attention that you only made use of id's and no classes. Due to the fact that you've use only id's, you tend to repeat yourself quite a lot. This can be a problem if you need to make changes. If a style is going to be used multiple times, make the use of classes instead.
-
When you have an element with an id or class you don't have to target the parent and the child. You can directly target that element.
// Instead of doing like this section#card > div#img { display: flex; align-items: center; justify-content: center; } // Do it like this #img { display: flex; align-items: center; justify-content: center; }
I hope this was helpful. Keep it up 👍👌
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord