react / styled-component / redux / yup

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Jay! 👋

  Congrats on finishing GURU challenge! 🎉 Forgive me for speaking so late, but I had a few days off. Your solution is flawless! I really like the animations you added. They look very smooth and the whole UI is great.

  • I don't think you need aria-labels in your header navigation links. It seems to me that they're self-descriptive.
  • It is different with the cart button tho. I'd add aria-label to button and keep my image alt text empty. Also change this text to something more descriptive - 'cart icon image' doesn't speak much.

  Good luck with that, have fun coding! 💪

  Marked as helpful

  2

  ---

  

  Jay•695

  @JunjiequanPosted over 3 years ago

  @tediko

  Thx, Tediko.

  I appreciate you point out the aria-label issues, I literrally abused aria-label attributes 😂. It reminds me that I suppose to add aria-control & aria-haspopup for modal as well to improve accessibility.

  0
• 

  Kakasi Daniel•130

  @Kakasi-DanielPosted over 3 years ago

  Nice!

  0

  ---

  

  Jay•695

  @JunjiequanPosted over 3 years ago

  @Kakasi-Daniel Thanks!

  0