React library, flexbox

Community feedback

• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hi! Terrence, I checked your work and your design responsiveness. I have some suggestions for you.

  1. I saw that your background image is not in centered position and In your code I found you have used background-size: cover; So instead of cover use background-size: contain; in order to make your background centered position.

  2. I checked your design responsiveness, But first let me tell you, you have used the desktop background as your mobile background and you need to add in media query that, if media query reach at certain point where mobile screen-width starts then change the background image and use mobile version image.

  Overall I would say Good, but needs more practice. I hope you understand.

  Good Luck

  Marked as helpful

  1

  ---

  

  Terrence Arceo•60

  @TerrenceArceoPosted almost 3 years ago

  @skyv26 Oh no!! it's totally fine! This helps me a lot thank you so much for your criticism!! I would def try these suggestions you gave me! <3

  1