React JS and Style Components

Community feedback

• 

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  Hi Nabil,

  Great work on finishing the project! Just some suggestions:

  • try to add some active effect on the button. Also don't forget to include cursor: pointer in the button's style.
  • when I tried inputting the form, it starts validating right away. It would be better to change it from onChange to onClick instead. If you are doing it the other way, then the button would be of no use here.

  I hope it helps! :) Great job too :)

  Marked as helpful

  0

  ---

  

  Nabil•160

  @Nabil19911Posted about 3 years ago

  @fidellim Hey Fidel Lim, I have done the need.

  1

  

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  @Nabil19911 great!

  1
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hiya, your solution looks good and seems nicely responsive! There's only a few small issues I noticed:

  1. Social links are missing aria-labels. You need to use these for links with no visible text description.

  2. The shadow on the button and the hover seem a bit excessive, you could go for something more subtle! ^^

  Marked as helpful

  0

  ---

  

  Nabil•160

  @Nabil19911Posted about 3 years ago

  @FluffyKas Thank you for your feedback I have done the need.

  0