
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I added an additional button and message for if no rating had been chosen.
Community feedback
- @shadowbanksPosted 9 days ago
Hello Simon,
Great job completing the challenge 🥳
I have a couple of suggestions for improvement:
- For better accessibility, it might be helpful to wrap each section in a
section
tag instead of adiv
. Regarding the use of twoh1
tags, it's generally recommended to have just one per page, but since only one will be visible at a time, it's likely fine. However, if you're using them purely for styling (like font size), you could consider usingh1
for the first section andh2
for the second. This would maintain the semantic structure and allow you to adjust the font size and weight as needed.
.
- The idea of handling an unselected rating is great! Instead of showing a separate view for the error and adding a back button, you could have the error message appear right above the rating options. This would improve the user experience by making it quicker and easier for users to update their choices without needing to navigate away.
Once again, great work! Happy coding :))
Marked as helpful0 - For better accessibility, it might be helpful to wrap each section in a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord