Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Random-Advice-Generator-with-Reactjs

Nonye 240

@4002-Nonye

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I just completed my first React project Any tips I could use to improve, please I am all ears.

Community feedback

@katjadanilova

Posted

Hey there!

The design looks good and has been implemented according to the initial description - well done! However, I would suggest not wrapping the advice-container in a spinner. Because both the spinner and the container are visible when the spinner is active, which is not the expected behavior. Additionally, the container jumps up and down every time the spinner appears or disappears.

Instead, you could have a separate div that wraps both the container and the spinner, and shows one or the other depending on the isLoading state.

Marked as helpful

1

@4002-nonye-practice

Posted

@katjadanilova thanks for this Katja!!! I really appreciate

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord