Random-Advice-Generator-with-Reactjs

Community feedback

• 

  Katja Danilova•340

  @katjadanilovaPosted almost 2 years ago

  Hey there!

  The design looks good and has been implemented according to the initial description - well done! However, I would suggest not wrapping the advice-container in a spinner. Because both the spinner and the container are visible when the spinner is active, which is not the expected behavior. Additionally, the container jumps up and down every time the spinner appears or disappears.

  Instead, you could have a separate div that wraps both the container and the spinner, and shows one or the other depending on the isLoading state.

  Marked as helpful

  1

  ---

  

  4002-nonye-practice•0

  @4002-nonye-practicePosted almost 2 years ago

  @katjadanilova thanks for this Katja!!! I really appreciate

  1