QR-Component-using-CSS-Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Abbaz•80

  @abbashcs18Posted over 1 year ago

  @0xAbdulKhalid Thank you for your valuable feedback and suggestions. I will do follow your suggestion for next challenge project

  0
• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  • You don't need to use .container and you can remove it. You'd better add the background color for the screen to the body, thus you don't lose the color.

  /* .container {
    display: flex;
    height: 700px;
    justify-content: center;
    align-items: center;
    background-color: var(--light-gray);
    width: 1440px;
    box-shadow: 5px 10px 50px rgba(0, 0, 0, 0.3);
  } */
  

  body{
     background-color: var(--light-gray);
  }
  

  • You don't need to use justify-items: center for the .card
  • If you use max-width, the card will be responsive

  .card {
    /* width: 300px; */
    max-width: 300px;
    /* justify-items: center; */
  }
  

  • In addition to that above, in order to make the card responsive and the image positioned completely on the card, you'd better add width: 100% to the img

  .card > img {
    /* width: 300px; */
    width: 100%;
  }
  

  • Finally, you don't need to use media queries because the solution will be responsive if you follow the steps above.

  Hope I am helpful. :)

  1

  ---

  

  Abbaz•80

  @abbashcs18Posted over 1 year ago

  @ecemgo Thank you so much for taking the time to review my code and provide feedback.

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @abbashcs18 I'm happy to help :)

  0