Design comparison
SolutionDesign
Solution retrospective
hello guys ! this is my solution for the qr code component. Please feel free to give a feedback to help me improve.
Thanks 😊😊
Community feedback
- @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
HTML
In order to fix the accessibility issues:
- You need to wrap your
<div class="back-round">
with the<main>
tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
CSS
- You can add this style into your
p
to give a blank betweenp
and the bottom of the card
p { margin-bottom: 2rem; }
Hope I am helpful. :)
Marked as helpful0 - You need to wrap your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord