Skip to content
Submitted 10 months ago

qr-code-component-main - Flexbox and Absolute Positioning

dkaffesā€¢140
@dkaffes
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my first challenge submission.

I would appreciate some feedback for the following issues:

  • Is the use of semantic elements correct? Should i keep footer outside of main?

  • I used width: 25% for the .card-component and gradually increased its value for smaller screens with media queries. Is the percentage value right? Is this overall approach correct?

Community feedback

  • Daniel šŸ›øā€¢44,310
    @danielmrz-devPosted 10 months ago

    Hello @dkaffes!

    Your solution looks excellent!

    I have just one suggestion:

    • Use <main> to wrap the main content instead of <main> and <article>.

    šŸ“Œ The tag <article> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

    This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord