QR-code-component using css Flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="card-container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Walid-Gs•220

  @Walid-GsPosted over 1 year ago

  • @0xAbdulKhalid , thank you so much for the feedback and the advices, i will use more semantic html tags in the future.

  • i did not use <main> because i thought it was too much for this small component.

  0
• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  In order to fix the accessibility issues:

  • You need to replace <div class="card-container"> with the <main class="card-container"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to include at least h1 element so you should use one <h1> element in the <main> tag. You can replace your <p class="card_title">Improve your front-end skills by building projects</p> element with the <h1 class="card_title">Improve your front-end skills by building projects</h1> element.
  • The <img> tag should include alt ="" attribute. You can apply like this:

  <img class="card_img" src="/images/image-qr-code.png" alt="qr-code"/>
  

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  Hope I am helpful. :)

  Marked as helpful

  0

  ---

  

  Walid-Gs•220

  @Walid-GsPosted over 1 year ago

  @ecemgo thank you so much for this helpful feedback and great recommendations, i will definitely use them in the next challenge.

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @Walid-Gs happy to help! :)

  1