qr-code-component

Community feedback

• 

  Saleiux•230

  @SaleiuxPosted 9 months ago

  Hi! good job with your project! Some suggestions:

  • It could be useful to start to use an external file for CSS, maybe it doesn't make sense for little project like this one but you will understand that for bigger projects will be better to have an external file
  • Your <p> text color is different from the one in the example, you can check in the style-guide the right color! Keep it!

  Marked as helpful

  2

  ---

  

  mirkodevs•20

  @mirkodevsPosted 9 months ago

  @Saleiux thanks for the feedback :)

  1
• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 9 months ago

  Hello there 👋 @mirkodevs.

  Good job on completing the challenge !

  Your project looks really good!

  I have suggestions about your code that might interest you.

  Consider adding a min-height of 100vh to the body element so as to centralize your project. Consider changing the background-color of the body element to hsl(212, 45%, 89%).

  body { 
    background-color: hsl(212, 45%, 89%);
    min-height: 100vh;
    align-items: center;
    display: flex;
    justify-content: center;
  }
  
  

  I hope it helps!

  Other than that, great job!

  Happy coding.

  0
• 

  Dêvid Teófilo•240

  @devid8642Posted 9 months ago

  First of all, congratulations on the solution, but I have some points to consider:

  Use an <h1> instead of an <h2>. For reasons of semantics and SEO, it is interesting that you first have an <h1> and then an <h2>, even if the style of the <h1> doesn't make sense because you can change the style in CSS;

  I believe it would be interesting to adjust the background color of the page to a lighter blue. In the style-guide.md file you have some useful color references but always feel free to adjust them as necessary;

  Again congratulations on the solution.

  0