Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component

@yousefnachat

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All Feedback Are Welcom Thank You In Advance

Community feedback

@lisztomania23

Posted

Hello, Youssef, I have made changes and submitted a pull request on your QR code component GitHub repository; merge it if you like, your images is not loading but will be.

Marked as helpful

1

@yousefnachat

Posted

@lisztomania23 ty i have just see your request in Github and i have accepte it and also will the image well show up now or still ?

1

@lisztomania23

Posted

@yousefnachat it is showing, and I also made another pull request to change the top margin of the card and set a responsive width property.

I removed the inline style from the card div <div class="card"> where it had "width: 22rem; margin: 20% 0 0 0", and instead, I added max-width: 22rem; and margin: auto; in the CSS.

Marked as helpful

0

@yousefnachat

Posted

@lisztomania23 ty for your help brother i will go see it and push it

1

@lisztomania23

Posted

@yousefnachat Happy coding, brother! 😊✨

Marked as helpful

0

@yousefnachat

Posted

@lisztomania23 soon i will lunch an other project i hope u will be there to see my code and tell me ur feedback

1

@lisztomania23

Posted

@yousefnachat Sure, I will be happy if I could help.

0

@lisztomania23

Posted

Hi, your images were not loading, so I made changes to the directory and created a pull request on GitHub. Anyway, your code looks good, really liked Bootstrap implementation.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord