Qr-Code-Component Challenge

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.

  • The section element is being used incorrectly ⚠️ and not needed for this challenge .

  • The article element should be wrapping the entire component ⚠️ after the main element.

  • The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • Remove the height and min-height in your component’s container as it is not needed. Your content itself, along with padding will create the “height”.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🤖

  Marked as helpful

  0

  ---

  

  P

  Aynur Demir•150

  @Maanlicht91Posted almost 2 years ago

  @vcarames Thank you so much for your helpful comments. But I am confused about using section vs div. Also I think you mean I needed to use article once for whole content so this means I can use div instead of article? This is my second challenge so I really care about your comments and try to fix my mistakes. Thank you again

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @Maanlicht91

  Glad I could help!

  A section and div are pretty much the same thing. They just have different uses.

  A section is used to define a group of related content, generally in full sites.

  A div can be used whenever there is not a semantically correct element available to use.

  While the article element is rarely used since it has two requirements for it be used; make sense on its own and can be independently distributable (can be used on any random site).

  For this challenge, it is not required since you already have a main as your container, but you’re correct, the article will wrap the entire card:

  <main>
    <article></article>
  </main>
  

  Hope this helps.

  Marked as helpful

  0