Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QRCode Page

Gyuro93 10

@Gyuro93

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@chinh1402

Posted

Congrats on finishing your project 🎉. Your solution looks okay, and I have a few suggestion to improve it

  1. In your code you use padding directly onto the image tag (.card img). That's not really ideal, because by using padding on image, you distorted its border-radius (you can try out yourself by giving it a bigger value of padding). Instead of that, you could: remove all of the padding options in your image, and instead of using width: 80%, and height: 80%, you should change to width: 100% in combination with adding 20px padding onto the card, the qr image would look much better
  2. The spacing between qr-image and headline is too large, I suggest reduce that part a bit; and change the color value to hsl(218, 44%, 22%)

I hope you find my suggestions useful!

Happy coding 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord