QRCode Page

Community feedback

• 

  Nguyễn Đức Chính•310

  @chinh1402Posted about 1 year ago

  Congrats on finishing your project 🎉. Your solution looks okay, and I have a few suggestion to improve it

  1. In your code you use padding directly onto the image tag (.card img). That's not really ideal, because by using padding on image, you distorted its border-radius (you can try out yourself by giving it a bigger value of padding). Instead of that, you could: remove all of the padding options in your image, and instead of using width: 80%, and height: 80%, you should change to width: 100% in combination with adding 20px padding onto the card, the qr image would look much better
  2. The spacing between qr-image and headline is too large, I suggest reduce that part a bit; and change the color value to hsl(218, 44%, 22%)

  I hope you find my suggestions useful!

  Happy coding 😊

  0